[bridge] Fix wrong mapping of WorkspaceStatus to prebuild when "snapshot" is missing #9924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geropl
force-pushed
the
gpl/9676-snapshots
branch
from
bdd4717 to
a8e3016
Compare
geropl
force-pushed
the
gpl/9676-snapshots
branch
from
a8e3016 to
26c173a
Compare
geropl
force-pushed
the
gpl/9676-snapshots
branch
from
26c173a to
ccddd3d
Compare
AlexTugarev
reviewed
May 11, 2022
| }[] = [ | ||
| { | ||
| name: "STOPPED", | ||
| expected: undefined, |
There was a problem hiding this comment.
with this change, the PrebuildWorkspace would not be updated on STOPPED events, or am I missing something?
There was a problem hiding this comment.
Yes, that mimics the previous behavior, which completely ignored anything except Stopping.
AlexTugarev
approved these changes
May 11, 2022
There was a problem hiding this comment.
/hold
@geropl, I don't want to block this PR just because I don't get the point from the previous comment. Your call, if you think that's OK.
|
/unhold |
roboquat
added
deployed: webapp
This was referenced May 13, 2022
Revert "[bridge] Fix wrong mapping of WorkspaceStatus to prebuild when "snapshot" is missing"
#10006
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Does what is says in the title, plus adding tests for the mapping. 🧘
Related Issue(s)
Fixes #9676
How to test
cd components/ws-manager-bridge && yarn testRelease Notes
Documentation